Skip to content

[bazel] Bump rules_python to 1.1.0 #15139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

[bazel] Bump rules_python to 1.1.0 #15139

merged 1 commit into from
Jan 23, 2025

Conversation

@shs96c
Copy link
Member

@shs96c shs96c commented Jan 23, 2025 •
edited by qodo-merge-pro bot
Loading

PR Type

enhancement, configuration changes

Description

  • Updated rules_python dependency to version 1.1.0.

  • Added precompile = "disabled" to py_library and pytest_test.

  • Improved Bazel configuration for Python test suites.

Changes walkthrough 📝

Relevant files
Enhancement
suite.bzl
Add `precompile` option to Python test suite                         

py/private/suite.bzl

  • Added precompile = "disabled" to py_library and pytest_test.
  • Enhanced Python test suite configuration.
    		• +2/-0     
    Configuration changes
    MODULE.bazel
    Bump `rules_python` dependency version                                     

    MODULE.bazel

    • Updated rules_python dependency from 0.33.0 to 1.1.0.
    		 +1/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 23, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Impact

    Disabling precompilation for Python tests may impact test execution performance. Verify this change is intentional and aligns with project requirements.

    precompile = "disabled",

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 23, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @shs96c shs96c merged commit a080ec5 into SeleniumHQ:trunk Jan 23, 2025
    9 checks passed
    @shs96c shs96c deleted the bump-rules-python branch January 23, 2025 15:15
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    @shs96c @sandeepsuryaprasad
    [bazel] Bump rules_python to 1.1.0 (SeleniumHQ#15139)
    424093f
    gryznar pushed a commit to gryznar/selenium that referenced this pull request May 17, 2025
    @shs96c @gryznar
    [bazel] Bump rules_python to 1.1.0 (SeleniumHQ#15139)
    e4c026a
    @dependabot dependabot bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot bot mentioned this pull request Oct 1, 2025
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @shs96c